]> git.proxmox.com Git - mirror_qemu.git/commit
qmp qemu-ga: Revert change that accidentally made qemu-ga accept "id"
authorMarkus Armbruster <armbru@redhat.com>
Tue, 3 Jul 2018 08:53:35 +0000 (10:53 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 3 Jul 2018 21:18:56 +0000 (23:18 +0200)
commit0fa39d0b0374b983535de8591e5e561401d1d5c6
tree59d236d557bab134147b6d32d2ed8434cd52f9f3
parentb5f8431040549da931b31892cbbde73b8724ff48
qmp qemu-ga: Revert change that accidentally made qemu-ga accept "id"

Commit cf869d53172 "qmp: support out-of-band (oob) execution" changed
how we check "id":

    Note that in the patch I exported qmp_dispatch_check_obj() to be
    used to check the request earlier, and at the same time allowed
    "id" field to be there since actually we always allow that.

The part after "and" is ill-advised: it makes qemu-ga accept and
ignore "id".  Revert.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180703085358.13941-10-armbru@redhat.com>
monitor.c
qapi/qmp-dispatch.c
tests/test-qga.c