]> git.proxmox.com Git - mirror_qemu.git/commit
block: Walk bs->children carefully in bdrv_drain_recurse
authorFam Zheng <famz@redhat.com>
Tue, 18 Apr 2017 14:30:43 +0000 (22:30 +0800)
committerFam Zheng <famz@redhat.com>
Tue, 18 Apr 2017 14:56:28 +0000 (22:56 +0800)
commit178bd438af5c95deef5073416c60396f88e97ec9
treee6637a6b80a892746126e6270dc009466fc64885
parent9c6b899f7a46893ab3b671e341a2234e9c0c060e
block: Walk bs->children carefully in bdrv_drain_recurse

The recursive bdrv_drain_recurse may run a block job completion BH that
drops nodes. The coming changes will make that more likely and use-after-free
would happen without this patch

Stash the bs pointer and use bdrv_ref/bdrv_unref in addition to
QLIST_FOREACH_SAFE to prevent such a case from happening.

Since bdrv_unref accesses global state that is not protected by the AioContext
lock, we cannot use bdrv_ref/bdrv_unref unconditionally.  Fortunately the
protection is not needed in IOThread because only main loop can modify a graph
with the AioContext lock held.

Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20170418143044.12187-2-famz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Tested-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
block/io.c