]> git.proxmox.com Git - mirror_qemu.git/commit
backends/iommufd: Remove mutex
authorCédric Le Goater <clg@redhat.com>
Thu, 21 Dec 2023 15:58:41 +0000 (16:58 +0100)
committerCédric Le Goater <clg@redhat.com>
Fri, 5 Jan 2024 20:25:20 +0000 (21:25 +0100)
commit19368b1905b4b917e915526fcbd5bfa3f7439451
tree68c1386eca69463621a74ecde5d6e4f4abb9a859
parentc2ab3a6f7411c895e538e8350fee8948ac07c1a0
backends/iommufd: Remove mutex

Coverity reports a concurrent data access violation because be->users
is being accessed in iommufd_backend_can_be_deleted() without holding
the mutex.

However, these routines are called from the QEMU main thread when a
device is created. In this case, the code paths should be protected by
the BQL lock and it should be safe to drop the IOMMUFD backend mutex.
Simply remove it.

Fixes: CID 1531550
Fixes: CID 1531549
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
backends/iommufd.c
include/sysemu/iommufd.h