]> git.proxmox.com Git - mirror_qemu.git/commit
Remove the core bluetooth code
authorThomas Huth <thuth@redhat.com>
Wed, 20 Nov 2019 09:10:13 +0000 (10:10 +0100)
committerThomas Huth <thuth@redhat.com>
Tue, 17 Dec 2019 08:01:14 +0000 (09:01 +0100)
commit1d4ffe8dc77cbc9aafe8bcf514ca0e43f85aaae3
tree7f4ae35a4b2b3aa47c889478fab9c95562fa67f1
parent43d68d0a94ef13058f6479b3dd490169a9a62966
Remove the core bluetooth code

It's been deprecated since QEMU v3.1. We've explicitly asked in the
deprecation message that people should speak up on qemu-devel in case
they are still actively using the bluetooth part of QEMU, but nobody
ever replied that they are really still using it.

I've tried it on my own to use this bluetooth subsystem for one of my
guests, but I was also not able to get it running anymore: When I was
trying to pass-through a real bluetooth device, either the guest did
not see the device at all, or the guest crashed.

Even worse for the emulated device: When running

 qemu-system-x86_64 -bt device:keyboard

QEMU crashes once you hit a key.

So it seems like the bluetooth stack is not only neglected, it is
completely bitrotten, as far as I can tell. The only attention that
this code got during the past years were some CVEs that have been
spotted there. So this code is a burden for the developers, without
any real benefit anymore. Time to remove it.

Note: hw/bt/Kconfig only gets cleared but not removed here yet.
Otherwise there is a problem with the *-softmmu/config-devices.mak.d
dependency files - they still contain a reference to this file which
gets evaluated first on some build hosts, before the file gets
properly recreated. To avoid breaking these builders, we still need
the file around for some time. It will get removed in a couple of
weeks instead.

Message-Id: <20191120091014.16883-4-thuth@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
19 files changed:
Makefile.objs
bt-host.c [deleted file]
bt-vhci.c [deleted file]
configure
hw/Kconfig
hw/Makefile.objs
hw/bt/Kconfig
hw/bt/Makefile.objs [deleted file]
hw/bt/core.c [deleted file]
hw/bt/hci-csr.c [deleted file]
hw/bt/hci.c [deleted file]
hw/bt/hid.c [deleted file]
hw/bt/l2cap.c [deleted file]
hw/bt/sdp.c [deleted file]
include/hw/bt.h [deleted file]
include/sysemu/bt.h [deleted file]
qemu-deprecated.texi
qemu-options.hx
vl.c