]> git.proxmox.com Git - mirror_qemu.git/commit
virtio-net: correctly copy vnet header when flushing TX
authorJason Wang <jasowang@redhat.com>
Tue, 2 Jan 2024 03:29:01 +0000 (11:29 +0800)
committerJason Wang <jasowang@redhat.com>
Thu, 25 Jan 2024 06:58:00 +0000 (14:58 +0800)
commit2220e8189fb94068dbad333228659fbac819abb0
tree6bba50644b12a34b2d0e406f07db9450d15157e8
parent4a4efae44f19528589204581e9e2fab69c5d39aa
virtio-net: correctly copy vnet header when flushing TX

When HASH_REPORT is negotiated, the guest_hdr_len might be larger than
the size of the mergeable rx buffer header. Using
virtio_net_hdr_mrg_rxbuf during the header swap might lead a stack
overflow in this case. Fixing this by using virtio_net_hdr_v1_hash
instead.

Reported-by: Xiao Lei <leixiao.nop@zju.edu.cn>
Cc: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: qemu-stable@nongnu.org
Cc: Mauro Matteo Cascella <mcascell@redhat.com>
Fixes: CVE-2023-6693
Fixes: e22f0603fb2f ("virtio-net: reference implementation of hash report")
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Jason Wang <jasowang@redhat.com>
hw/net/virtio-net.c