]> git.proxmox.com Git - mirror_qemu.git/commit
spapr-tpm-proxy: Drop misleading check
authorGreg Kurz <groug@kaod.org>
Mon, 9 Sep 2019 18:10:09 +0000 (20:10 +0200)
committerDavid Gibson <david@gibson.dropbear.id.au>
Fri, 4 Oct 2019 00:25:23 +0000 (10:25 +1000)
commit226c9d15df0a9c9e94fc30c373cdefbc4156d8dd
treed63879015b822760159c836e6afe30384b1c14be
parentf42b6f535c290046d10aebf1796fb46957dfa8e6
spapr-tpm-proxy: Drop misleading check

Coverity is reporting in CID 1405304 that tpm_execute() may pass a NULL
tpm_proxy->host_path pointer to open(). This is based on the fact that
h_tpm_comm() does a NULL check on tpm_proxy->host_path and then passes
tpm_proxy to tpm_execute().

The check in h_tpm_comm() is abusive actually since a spapr-proxy-tpm
requires a non NULL host_path property, as checked during realize.

Fixes: 0fb6bd073230
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <156805260916.1779401.11054185183758185247.stgit@bahia.lan>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr_tpm_proxy.c