]> git.proxmox.com Git - mirror_qemu.git/commit
migration: Fix use-after-free of migration state object
authorFabiano Rosas <farosas@suse.de>
Fri, 19 Jan 2024 23:39:18 +0000 (20:39 -0300)
committerPeter Xu <peterx@redhat.com>
Mon, 29 Jan 2024 03:02:12 +0000 (11:02 +0800)
commit27eb8499edb2bc952c29ddae0bdac9fc959bf7b1
treea82c4f9d7959ed2d37b0f0bd320a92c2a8093ef5
parent0a5d1108aba6308752a82201a441f957e5937211
migration: Fix use-after-free of migration state object

We're currently allowing the process_incoming_migration_bh bottom-half
to run without holding a reference to the 'current_migration' object,
which leads to a segmentation fault if the BH is still live after
migration_shutdown() has dropped the last reference to
current_migration.

In my system the bug manifests as migrate_multifd() returning true
when it shouldn't and multifd_load_shutdown() calling
multifd_recv_terminate_threads() which crashes due to an uninitialized
multifd_recv_state.

Fix the issue by holding a reference to the object when scheduling the
BH and dropping it before returning from the BH. The same is already
done for the cleanup_bh at migrate_fd_cleanup_schedule().

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1969
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240119233922.32588-2-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
migration/migration.c