]> git.proxmox.com Git - mirror_qemu.git/commit
migration/postcopy: postpone setting PostcopyState to END
authorWei Yang <richardw.yang@linux.intel.com>
Sun, 6 Oct 2019 00:02:48 +0000 (08:02 +0800)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Fri, 11 Oct 2019 13:57:22 +0000 (14:57 +0100)
commit2d49bacda00876736c746ce1fcea006a128bef6b
tree2c1f63a48de14b96932342224bc1d85f8e938611
parent2a461c2467bb58e034c857e47a4a530bdca22227
migration/postcopy: postpone setting PostcopyState to END

There are two places to call function postcopy_ram_incoming_cleanup()

    postcopy_ram_listen_thread on migration success
    loadvm_postcopy_handle_listen one setup failure

On success, the vm will never accept another migration. On failure,
PostcopyState is transited from LISTENING to END and would be checked in
qemu_loadvm_state_main(). If PostcopyState is RUNNING, migration would
be paused and retried.

Currently PostcopyState is set to END in function
postcopy_ram_incoming_cleanup(). With above analysis, we can take this
step out and postpone this till the end of listen thread to indicate the
listen thread is done.

This is a preparation patch for later cleanup.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Message-Id: <20191006000249.29926-3-richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  Fixed up in merge to the 1 parameter postcopy_state_set
migration/postcopy-ram.c
migration/savevm.c