]> git.proxmox.com Git - mirror_qemu.git/commit
authz-pam: Check that 'service' property is set
authorKevin Wolf <kwolf@redhat.com>
Tue, 17 Nov 2020 16:30:44 +0000 (17:30 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 18 Nov 2020 10:51:35 +0000 (10:51 +0000)
commit3428455df9302b2b924e380cb90a77ca1ce5001e
treeee82f874bae66e84b9c908e738c718f1b9f77c86
parent8e26ae7bb58d10c04599eabd265217da050514a4
authz-pam: Check that 'service' property is set

If the 'service' property is not set, we'll call pam_start() with a NULL
pointer for the service name. This fails and leaves a message like this
in the syslog:

qemu-storage-daemon[294015]: PAM pam_start: invalid argument: service == NULL

Make specifying the property mandatory and catch the error already
during the creation of the object.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
authz/pamacct.c