]> git.proxmox.com Git - mirror_qemu.git/commit
blkdebug: Simplify override logic
authorEric Blake <eblake@redhat.com>
Sat, 29 Apr 2017 19:14:17 +0000 (14:14 -0500)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 3 Aug 2017 21:01:15 +0000 (16:01 -0500)
commit3ae74003b55d821a1b3ee92d04cfa18528e0334d
tree2998521d1f45cb3e6e9329e0973f7ab0203920a9
parent577cf9e6bb3af542b2ea691e1a1b367590b0c6a2
blkdebug: Simplify override logic

Rather than store into a local variable, then copy to the struct
if the value is valid, then reporting errors otherwise, it is
simpler to just store into the struct and report errors if the
value is invalid.  This however requires that the struct store
a 64-bit number, rather than a narrower type.  Likewise, setting
a sane errno value in ret prior to the sequence of parsing and
jumping to out: on error makes it easier for the next patch to
add a chain of similar checks.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-id: 20170429191419.30051-8-eblake@redhat.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
(cherry picked from commit 3dc834f8795a46f919d90b1e5369308628858601)
* prereq for 81c219a
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/blkdebug.c