]> git.proxmox.com Git - mirror_qemu.git/commit
migration: equation is more proper than and to check LOADVM_QUIT
authorWei Yang <richardw.yang@linux.intel.com>
Thu, 18 Jul 2019 06:42:57 +0000 (14:42 +0800)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 14 Aug 2019 16:33:14 +0000 (17:33 +0100)
commit4695ce3fdcb636384eac743cee9a1b6375ad0ccb
treeb619d60426252b3e83282c84217971cb2d5c199c
parent5d0980a459774a52e3f3729cee0a2562d11026d2
migration: equation is more proper than and to check LOADVM_QUIT

LOADVM_QUIT allows a command to quit all layers of nested loadvm loops,
while current return value check is not that proper even it works now.

Current return value check "ret & LOADVM_QUIT" would return true if
bit[0] is 1. This would be true when ret is -1 which is used to indicate
an error of handling a command.

Since there is only one place return LOADVM_QUIT and no other
combination of return value, use "ret == LOADVM_QUIT" would be more
proper.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Message-Id: <20190718064257.29218-1-richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/savevm.c