]> git.proxmox.com Git - mirror_qemu.git/commit
virtio-blk: add "discard" and "write-zeroes" properties
authorStefano Garzarella <sgarzare@redhat.com>
Thu, 21 Feb 2019 10:33:07 +0000 (11:33 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 22 Feb 2019 09:42:16 +0000 (09:42 +0000)
commit5c81161f804144b146607f890e84613a4cbad95c
treedf55db0d4d94ecb8f75a3f62c3e2e789425d2d2b
parentbbe8bd4d85d80442f87774d7bffaca11f2c02b9b
virtio-blk: add "discard" and "write-zeroes" properties

In order to avoid migration issues, we enable DISCARD and
WRITE_ZEROES features only for machine type >= 4.0

As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the
list [1], DISCARD operation should not have security implications
(eg. page cache attacks), so we can enable it by default.

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00504.html

Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20190221103314.58500-4-sgarzare@redhat.com
Message-Id: <20190221103314.58500-4-sgarzare@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/block/virtio-blk.c
hw/core/machine.c