]> git.proxmox.com Git - mirror_qemu.git/commit
block: Null pointer dereference in blk_root_get_parent_desc()
authorLiam Merwick <Liam.Merwick@oracle.com>
Mon, 5 Nov 2018 21:38:36 +0000 (21:38 +0000)
committerMax Reitz <mreitz@redhat.com>
Mon, 12 Nov 2018 16:49:21 +0000 (17:49 +0100)
commit602414d1232723d92836babe8d7014b57b93e4d9
tree2188b97580e434244b57c845c1efc1ddae5ec68e
parentc2032289b0c46597a4da7017a7869f2b41f8be16
block: Null pointer dereference in blk_root_get_parent_desc()

The dev_id returned by the call to blk_get_attached_dev_id() in
blk_root_get_parent_desc() can be NULL (an internal call to
object_get_canonical_path may have returned NULL).

Instead of just checking this case before before dereferencing,
adjust blk_get_attached_dev_id() to return the empty string if no
object path can be found (similar to the case when blk->dev is NULL
and an empty string is returned).

Signed-off-by: Liam Merwick <Liam.Merwick@oracle.com>
Message-id: 1541453919-25973-3-git-send-email-Liam.Merwick@oracle.com
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/block-backend.c