]> git.proxmox.com Git - mirror_qemu.git/commit
memory: don't sign-extend 32-bit writes
authorLadi Prosek <lprosek@redhat.com>
Thu, 26 Jan 2017 14:22:37 +0000 (15:22 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 27 Jan 2017 17:08:00 +0000 (18:08 +0100)
commit6da67de6803e93cbb7e93ac3497865832f8c00ea
treeb2c3d76a34f230b34c012482cc7f7c189f5f97f3
parent777357d758d937c9dd83082c39aff9f1e53e9ba3
memory: don't sign-extend 32-bit writes

ldl_p has a signed return type so assigning it to uint64_t implicitly
sign-extends the value. This results in devices with min_access_size = 8
seeing unexpected values passed to their write handlers.

Example: guest performs a 32-bit write of 0x80000000 to an mmio region
and the handler receives 0xFFFFFFFF80000000 in its value argument.

Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Message-Id: <1485440557-10384-1-git-send-email-lprosek@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
exec.c