]> git.proxmox.com Git - mirror_qemu.git/commit
projects / mirror_qemu.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 87bfffd) | patch
hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive
authorDavid Woodhouse <dwmw@amazon.co.uk>
Thu, 9 Nov 2023 15:21:13 +0000 (15:21 +0000)
committerDavid Woodhouse <dwmw@amazon.co.uk>
Tue, 21 Nov 2023 11:45:06 +0000 (11:45 +0000)
commit6f7997e0047e57a9e4f6a0958569f480d07f6538
treeea8fd4366d8daf57535e459ebb06896ae0f7f325tree
parent87bfffdf757f3c0a68432a9ec49d96c8908d02e8commit | diff
hw/xen: clean up xen_block_find_free_vdev() to avoid Coverity false positive

Coverity couldn't see that nr_existing was always going to be zero when
qemu_xen_xs_directory() returned NULL in the ENOENT case (CID 1523906).

Perhaps more to the point, neither could Peter at first glance. Improve
the code to hopefully make it clearer to Coverity and human reviewers
alike.

Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Paul Durrant <paul@xen.org>
hw/block/xen-block.c diff | blob | blame | history
QEMU mirror