]> git.proxmox.com Git - mirror_qemu.git/commit
migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable
authorAshijeet Acharya <ashijeetacharya@gmail.com>
Mon, 13 Feb 2017 18:04:48 +0000 (23:34 +0530)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Tue, 28 Feb 2017 11:30:22 +0000 (11:30 +0000)
commit7562f90707aa1f409ba2312569cb791241fca045
treed5981b7fbec7402b66053072587cd48793cc5ff0
parent9cd49026aa3af71a06587a41ece54a8c25c57f88
migrate: Introduce a 'dc->vmsd' check to avoid segfault for --only-migratable

Commit a3a3d8c7 introduced a segfault bug while checking for
'dc->vmsd->unmigratable' which caused QEMU to crash when trying to add
devices which do no set their 'dc->vmsd' yet while initialization.
Place a 'dc->vmsd' check prior to it so that we do not segfault for
such devices.

NOTE: This doesn't compromise the functioning of --only-migratable
option as all the unmigratable devices do set their 'dc->vmsd'.

Introduce a new function check_migratable() and move the
only_migratable check inside it, also use stubs to avoid user-mode qemu
build failures.

Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
Message-Id: <1487009088-23891-1-git-send-email-ashijeetacharya@gmail.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
hw/core/qdev.c
hw/usb/bus.c
include/migration/migration.h
migration/migration.c
qdev-monitor.c
stubs/vmstate.c