]> git.proxmox.com Git - mirror_qemu.git/commit
Hexagon (gen_tcg_funcs.py): avoid duplicated tcg code on A_CVI_NEW
authorMatheus Tavares Bernardino <quic_mathbern@quicinc.com>
Fri, 30 Sep 2022 20:08:23 +0000 (17:08 -0300)
committerTaylor Simpson <tsimpson@quicinc.com>
Mon, 3 Oct 2022 18:07:44 +0000 (11:07 -0700)
commit772b3eb4b4fe15f0595bd95923778a5a0f3558cc
treeb5534efaf1261c45217d36f7ff3c0559dc7f0759
parent661ad999c554d1cc99ff96b3baf3ff4acbe2ecee
Hexagon (gen_tcg_funcs.py): avoid duplicated tcg code on A_CVI_NEW

Hexagon instructions with the A_CVI_NEW attribute produce a vector value
that can be used in the same packet. The python function responsible for
generating code for such instructions has a typo ("if" instead of
"elif"), which makes genptr_dst_write_ext() be executed twice, thus also
generating the same tcg code twice. Fortunately, this doesn't cause any
problems for correctness, but it is less efficient than it could be. Fix
it by using an "elif" and avoiding the unnecessary extra code gen.

Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <fa706b192b2a3a0ffbd399fa8dbf0d5b2c5b82d9.1664568492.git.quic_mathbern@quicinc.com>
target/hexagon/gen_tcg_funcs.py