]> git.proxmox.com Git - mirror_qemu.git/commit
qom: Change object_get_canonical_path_component() not to malloc
authorMarkus Armbruster <armbru@redhat.com>
Tue, 14 Jul 2020 16:02:00 +0000 (18:02 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 21 Jul 2020 14:23:43 +0000 (16:23 +0200)
commit7a309cc95b862be74711e7a35997daa3f885651a
tree1417043015cf7f35de0ebd21ff2d72a05a5b3b52
parentaf3d69058e09bede9900f266a618ed11f76f49f3
qom: Change object_get_canonical_path_component() not to malloc

object_get_canonical_path_component() returns a malloced copy of a
property name on success, null on failure.

19 of its 25 callers immediately free the returned copy.

Change object_get_canonical_path_component() to return the property
name directly.  Since modifying the name would be wrong, adjust the
return type to const char *.

Drop the free from the 19 callers become simpler, add the g_strdup()
to the other six.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200714160202.3121879-4-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
23 files changed:
backends/hostmem.c
block/throttle-groups.c
gdbstub.c
hw/arm/xlnx-zynqmp.c
hw/block/nvme.c
hw/core/machine-qmp-cmds.c
hw/core/machine.c
hw/mem/nvdimm.c
hw/mem/pc-dimm.c
hw/misc/ivshmem.c
hw/ppc/spapr_drc.c
hw/ppc/trace-events
hw/virtio/virtio-crypto.c
hw/virtio/virtio-mem.c
hw/virtio/virtio-pmem.c
include/qom/object.h
iothread.c
net/net.c
qom/object.c
qom/qom-hmp-cmds.c
scsi/pr-manager-helper.c
scsi/pr-manager.c
softmmu/memory.c