]> git.proxmox.com Git - mirror_qemu.git/commit
migration/postcopy: make PostcopyDiscardState a static variable
authorWei Yang <richardw.yang@linux.intel.com>
Wed, 24 Jul 2019 01:07:21 +0000 (09:07 +0800)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 14 Aug 2019 16:33:14 +0000 (17:33 +0100)
commit810cf2bbd4c5c1417bda8bec49caf0ababc22860
tree5e1fea316fe52acd81cf3c43ab1f95da17813b81
parent10da4a368992a5950abd07673ba8311fbbe667f5
migration/postcopy: make PostcopyDiscardState a static variable

In postcopy-ram.c, we provide three functions to discard certain
RAMBlock range:

  * postcopy_discard_send_init()
  * postcopy_discard_send_range()
  * postcopy_discard_send_finish()

Currently, we allocate/deallocate PostcopyDiscardState for each RAMBlock
on sending discard information to destination. This is not necessary and
the same data area could be reused for each RAMBlock.

This patch defines PostcopyDiscardState a static variable. By doing so:

  1) avoid memory allocation and deallocation to the system
  2) avoid potential failure of memory allocation
  3) hide some details for their users

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Message-Id: <20190724010721.2146-1-richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/postcopy-ram.c
migration/postcopy-ram.h
migration/ram.c