]> git.proxmox.com Git - mirror_qemu.git/commit
pseries: Enforce homogeneous threads-per-core
authorDavid Gibson <david@gibson.dropbear.id.au>
Sun, 2 Apr 2017 06:14:30 +0000 (16:14 +1000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Mon, 3 Apr 2017 03:46:18 +0000 (13:46 +1000)
commit8149e2992f7811355cc34721b79d69d1a3a667dd
treec8961f95c64041375f4dbca2a35b2756d9184997
parent95b31d709ba343ad237c3630047ee7438bac4065
pseries: Enforce homogeneous threads-per-core

For reasons that may be useful in future, CPU core objects, as used on the
pseries machine type have their own nr-threads property, potentially
allowing cores with different numbers of threads in the same system.

If the user/management uses the values specified in query-hotpluggable-cpus
as they're expected to do, this will never matter in pratice.  But that's
not actually enforced - it's possible to manually specify a core with
a different number of threads from that in -smp.  That will confuse the
platform - most immediately, this can be used to create a CPU thread with
index above max_cpus which leads to an assertion failure in
spapr_cpu_core_realize().

For now, enforce that all cores must have the same, standard, number of
threads.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
hw/ppc/spapr.c