]> git.proxmox.com Git - mirror_qemu.git/commit
block, block-backend: write some hot coroutine wrappers by hand
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 7 Apr 2023 15:33:03 +0000 (17:33 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 11 Apr 2023 14:46:49 +0000 (16:46 +0200)
commit81f730d4d0e8af9c0211c3fedf406df0046341a9
treee0d6ed4cd1dd736e9e4f1e6b2ba5bea0c3617d14
parent9ed98cae151368cc89c4bb77c9f325f7185e8f09
block, block-backend: write some hot coroutine wrappers by hand

The introduction of the graph lock is causing blk_get_geometry, a hot function
used in the I/O path, to create a coroutine.  However, the only part that really
needs to run in coroutine context is the call to bdrv_co_refresh_total_sectors,
which in turn only happens in the rare case of host CD-ROM devices.

So, write by hand the three wrappers on the path from blk_co_get_geometry to
bdrv_co_refresh_total_sectors, so that the coroutine wrapper is only created
if bdrv_nb_sectors actually calls bdrv_refresh_total_sectors.

Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20230407153303.391121-9-pbonzini@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
block/block-backend.c
include/block/block-io.h
include/sysemu/block-backend-io.h