]> git.proxmox.com Git - mirror_qemu.git/commit
qdev: Don't stop applying globals on first error
authorEduardo Habkost <ehabkost@redhat.com>
Wed, 15 Jun 2016 17:59:46 +0000 (14:59 -0300)
committerEduardo Habkost <ehabkost@redhat.com>
Thu, 7 Jul 2016 18:24:47 +0000 (15:24 -0300)
commit823efc5d26671e4737b2951d65b0565806ee43ab
treeef31f26428b7c52d56f2d827f2895205e216368d
parent4f4a9ca4a4386c137301b3662faba076455ff15a
qdev: Don't stop applying globals on first error

qdev_prop_set_globals_for_type() stops applying global properties
on the first error. It is a leftover from when QEMU exited on any
error when applying global property. Commit 25f8dd9 changed the
fatal error to a warning, but neglected to drop the stopping.
Fix that.

For example, the following command-line will not set CPUID level
to 3, but will warn only about "x86_64-cpu.vendor" being ignored.

  $ ./x86_64-softmmu/qemu-system-x86_64 \
      -global x86_64-cpu.vendor=x \
      -global x86_64-cpu.level=3
  qemu-system-x86_64: Warning: global x86_64-cpu.vendor=x ignored: Property '.vendor' doesn't take value 'x'

Fix this by not returning from qdev_prop_set_globals_for_type()
on the first error.

Cc: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
hw/core/qdev-properties.c