]> git.proxmox.com Git - mirror_qemu.git/commit
enforce use of G_GNUC_PRINTF attributes
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 19 Dec 2022 13:02:05 +0000 (08:02 -0500)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 11 Jan 2023 09:44:34 +0000 (10:44 +0100)
commit88a0ef00d70c61fdb46ee88ced87046dfb11eb3f
tree981808331f53cefd9ef7a7ce6ebe28b578db5795
parent0472b2e541971d162a9bbca7541c8f9299e9d78f
enforce use of G_GNUC_PRINTF attributes

We've been very gradually adding G_GNUC_PRINTF annotations
to functions over years. This has been useful in detecting
certain malformed printf strings, or cases where we pass
user data as the printf format which is a potential security
flaw.

Given the inherant memory corruption danger in use of format
strings vs mis-matched variadic arguments, it is worth applying
G_GNUC_PRINTF to all functions using printf, even if we know
they are safe.

The compilers can reasonably reliably identify such places
with the -Wsuggest-attribute=format / -Wmissing-format-attribute
flags.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20221219130205.687815-7-berrange@redhat.com>
[-Wsuggest-attribute=format and -Wmissing-format-attribute are
 synonyms, only include one; disable it for testfloat. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
configure
tests/fp/meson.build