]> git.proxmox.com Git - mirror_qemu.git/commit
ohci: fix resource cleanup leak
authorGonglei <arei.gonglei@huawei.com>
Wed, 18 Mar 2015 09:33:48 +0000 (17:33 +0800)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 20 Mar 2015 07:50:06 +0000 (08:50 +0100)
commit88dd1b8d0063ff16c54dc19c8b52508a00108f50
treeb6a07f49e1c2623dc7c548dc1c759de73d948899
parent537e572a7f807d7371a73ea5ffd9ce8d2487ff0c
ohci: fix resource cleanup leak

When hot-unplugging the usb controllers (ehci/uhci),
we have to clean all resouce of these devices,
involved registered reset handler. Otherwise, it
may cause NULL pointer access and/or segmentation fault
if we reboot the guest os after hot-unplugging.

Let's hook up reset via DeviceClass->reset() and drop
the qemu_register_reset() call. Then Qemu will register
and unregister the reset handler automatically.

Ohci does't support hotplugging/hotunplugging yet, but
existing resource cleanup leak logic likes ehci/uhci.

Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
hw/usb/hcd-ohci.c