]> git.proxmox.com Git - mirror_qemu.git/commit
virtio-gpu: fix crashes upon warm reboot with vga mode
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Fri, 3 Aug 2018 15:32:35 +0000 (17:32 +0200)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 7 Aug 2018 14:03:58 +0000 (15:03 +0100)
commit93f874fe9dbe0b997b5a9459840957efd13d7191
tree44484b3c3f6d071bf7dce2548d3bfbc61802a805
parent09b94ac0f29db3b022a77a5aa50dc9e37032689d
virtio-gpu: fix crashes upon warm reboot with vga mode

With vga=775 on the Linux command line a first boot of the VM running
Linux works fine. After a warm reboot it crashes during Linux boot.

Before that, valgrind points out bad memory write to console
surface. The VGA code is not aware that virtio-gpu got a message
surface scanout when the display is disabled. Let's reset VGA graphic
mode when it is the case, so that a new display surface is created
when doing further VGA operations.

https://bugs.launchpad.net/qemu/+bug/1784900/

Reported-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Message-id: 20180803153235.4134-1-marcandre.lureau@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/display/virtio-gpu.c
hw/display/virtio-vga.c
include/hw/virtio/virtio-gpu.h