]> git.proxmox.com Git - mirror_qemu.git/commit
linux-user: Fix unaligned memory access in prlimit64 syscall
authorIlya Leoshkevich <iii@linux.ibm.com>
Fri, 24 Feb 2023 00:39:06 +0000 (01:39 +0100)
committerLaurent Vivier <laurent@vivier.eu>
Fri, 10 Mar 2023 19:42:00 +0000 (20:42 +0100)
commit9c1da8b5ee7f6e80e6b683e7fb73df1029a7cbbe
treecc36882bc54296678a450d7628b5f80164658031
parentfa2229dbf8e529f767d86db9e39b7e829c6759ed
linux-user: Fix unaligned memory access in prlimit64 syscall

target_rlimit64 contains uint64_t fields, so it's 8-byte aligned on
some hosts, while some guests may align their respective type on a
4-byte boundary. This may lead to an unaligned access, which is an UB.

Fix by defining the fields as abi_ullong. This makes the host alignment
match that of the guest, and lets the compiler know that it should emit
code that can deal with the guest alignment.

While at it, also use __get_user() and __put_user() instead of
tswap64().

Fixes: 163a05a8398b ("linux-user: Implement prlimit64 syscall")
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20230224003907.263914-2-iii@linux.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
linux-user/generic/target_resource.h
linux-user/syscall.c