]> git.proxmox.com Git - mirror_qemu.git/commit
trace: fix "-trace file=..."
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 9 Feb 2021 14:57:58 +0000 (15:57 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 6 Mar 2021 10:42:57 +0000 (11:42 +0100)
commit9f45a641097b0a54c673fe3399c7a8ccb6f06af1
treee4f72f6f63c0a70779de9a97bab3db5ff23b1ea9
parentdc1d91ac567c49cf07d8312c97b4a02e25047d50
trace: fix "-trace file=..."

Because trace_opt_parse always deletes the options it has parsed,
trace_init_file's call to qemu_find_opts_singleton always
creates an empty -trace option group.  Therefore, the subsequent
qemu_opt_get(opts, "file") always returns NULL.

To fix this, save the last "-trace file=..." option in a global
variable and use it later in trace_init_file.

This is similar to what was done before commit 92eecfff32 ("trace:
remove argument from trace_init_file", 2020-11-11), except contained
within trace/control.c and without memory leaks.

Fixes: 92eecfff32 ("trace: remove argument from trace_init_file", 2020-11-11)
Cc: stefanha@redhat.com
Reported-by: armbru@redhat.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20210209145759.141231-2-pbonzini@redhat.com>
trace/control.c