]> git.proxmox.com Git - mirror_qemu.git/commit
qemu-img: Use BlockNodeInfo
authorHanna Reitz <hreitz@redhat.com>
Mon, 20 Jun 2022 16:26:57 +0000 (18:26 +0200)
committerKevin Wolf <kwolf@redhat.com>
Wed, 1 Feb 2023 15:52:33 +0000 (16:52 +0100)
commitb1f4cd1589a16fec02f264a09bd3560e4ccce3c2
treef5fd305a98288054279ff70f580d6ec8f8ef89ca
parenta2085f8909377b6df738f6c3f7ee6db4d16da8f7
qemu-img: Use BlockNodeInfo

qemu-img info never uses ImageInfo's backing-image field, because it
opens the backing chain one by one with BDRV_O_NO_BACKING, and prints
all backing chain nodes' information consecutively.  Use BlockNodeInfo
to make it clear that we only print information about a single node, and
that we are not using the backing-image field.

Notably, bdrv_image_info_dump() does not evaluate the backing-image
field, so we can easily make it take a BlockNodeInfo pointer (and
consequentially rename it to bdrv_node_info_dump()).  It makes more
sense this way, because again, the interface now makes it syntactically
clear that backing-image is ignored by this function.

Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Message-Id: <20220620162704.80987-6-hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/monitor/block-hmp-cmds.c
block/qapi.c
include/block/qapi.h
qapi/block-core.json
qemu-img.c