]> git.proxmox.com Git - mirror_qemu.git/commit
migration/rdma: Fix save_page method to fail on polling error
authorMarkus Armbruster <armbru@redhat.com>
Thu, 21 Sep 2023 12:13:06 +0000 (14:13 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 29 Sep 2023 06:13:57 +0000 (08:13 +0200)
commitbbde656263d80429b51017b077d9b4064ba13b01
treea6720b6713124da5b7716fbf3f5628a56fb04264
parent36e9aab3c569d4c9ad780473596e18479838d1aa
migration/rdma: Fix save_page method to fail on polling error

qemu_rdma_save_page() reports polling error with error_report(), then
succeeds anyway.  This is because the variable holding the polling
status *shadows* the variable the function returns.  The latter
remains zero.

Broken since day one, and duplicated more recently.

Fixes: 2da776db4846 (rdma: core logic)
Fixes: b390afd8c50b (migration/rdma: Fix out of order wrid)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Message-ID: <20230921121312.1301864-2-armbru@redhat.com>
migration/rdma.c