]> git.proxmox.com Git - mirror_qemu.git/commit
virtfs: error out gracefully when mandatory suboptions are missing
authorGreg Kurz <groug@kaod.org>
Mon, 4 Sep 2017 07:59:01 +0000 (09:59 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 5 Sep 2017 20:42:17 +0000 (15:42 -0500)
commitc24c5910b78db714efe0698d9d7a8868656d22d8
treef46f6927b23781f018baec56a80bd0cfc09282a8
parent2d1bbf51c2cb948da4b6fd5f91cf3ecc80b28156
virtfs: error out gracefully when mandatory suboptions are missing

We internally convert -virtfs to -fsdev/-device. If the user doesn't
provide the path or security_model suboptions, and the fsdev backend
requires them, we hit an assertion when populating the internal -fsdev
option:

util/qemu-option.c:547: opt_set: Assertion `opt->str' failed.
Aborted (core dumped)

Let's test the suboption presence on the command line before trying
to set it in the internal -fsdev option, and let the backend code
error out gracefully (ie, like it already does when the user passes
-fsdev on the command line).

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
(cherry picked from commit 32b6943699948f7adc35ada233fbd25daffad5e9)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
vl.c