]> git.proxmox.com Git - mirror_qemu.git/commit
net/vhost-net: do not assert on null pointer return from tap_get_vhost_net()
authorAni Sinha <anisinha@redhat.com>
Wed, 28 Jun 2023 11:28:04 +0000 (16:58 +0530)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 28 Jun 2023 11:53:14 +0000 (07:53 -0400)
commitca3fcdeeeef56f46a7ac7b2408eda608d59be6f1
tree5776d8d338476512a863eae46c6ff079b7872975
parenta0d7215e339b61c7d7a7b3fcf754954d80d93eb8
net/vhost-net: do not assert on null pointer return from tap_get_vhost_net()

When 'vhost=off' or no vhost specific options at all are passed for the tap
net-device backend, tap_get_vhost_net() can return NULL. The function
net_init_tap_one() does not call vhost_net_init() on such cases and therefore
vhost_net pointer within the tap device state structure remains NULL. Hence,
assertion here on a NULL pointer return from tap_get_vhost_net() would not be
correct. Remove it and fix the crash generated by qemu upon initialization in
the following call chain :

qdev_realize() -> pci_qdev_realize() -> virtio_device_realize() ->
virtio_bus_device_plugged() -> virtio_net_get_features() -> get_vhost_net()

Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Cédric Le Goater <clg@redhat.com>
Fixes: 0e994668d00c9c ("vhost_net: add an assertion for TAP client backends")
Reported-by: Cédric Le Goater <clg@redhat.com>
Report: <abab7a71-216d-b103-fa47-70bdf9dc0080@redhat.com>
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Message-Id: <20230628112804.36676-1-anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/net/vhost_net.c