]> git.proxmox.com Git - mirror_qemu.git/commit
vfio/pci: Clear MSI-X IRQ index always
authorCédric Le Goater <clg@redhat.com>
Thu, 25 Jan 2024 13:27:36 +0000 (14:27 +0100)
committerCédric Le Goater <clg@redhat.com>
Mon, 29 Jan 2024 07:26:25 +0000 (08:26 +0100)
commitd2b668fca5652760b435ce812a743bba03d2f316
tree79cf535a425c0ac6334a91a2ea9bc5eb7c629d0b
parent850051b94b4eac2e2eec985b313d840bd5eddb44
vfio/pci: Clear MSI-X IRQ index always

When doing device assignment of a physical device, MSI-X can be
enabled with no vectors enabled and this sets the IRQ index to
VFIO_PCI_MSIX_IRQ_INDEX. However, when MSI-X is disabled, the IRQ
index is left untouched if no vectors are in use. Then, when INTx
is enabled, the IRQ index value is considered incompatible (set to
MSI-X) and VFIO_DEVICE_SET_IRQS fails. QEMU complains with :

qemu-system-x86_64: vfio 0000:08:00.0: Failed to set up TRIGGER eventfd signaling for interrupt INTX-0: VFIO_DEVICE_SET_IRQS failure: Invalid argument

To avoid that, unconditionaly clear the IRQ index when MSI-X is
disabled.

Buglink: https://issues.redhat.com/browse/RHEL-21293
Fixes: 5ebffa4e87e7 ("vfio/pci: use an invalid fd to enable MSI-X")
Cc: Jing Liu <jing2.liu@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Cédric Le Goater <clg@redhat.com>
hw/vfio/pci.c