]> git.proxmox.com Git - mirror_qemu.git/commit
block: Reuse bs as backing hd for drive-backup sync=none
authorFam Zheng <famz@redhat.com>
Tue, 2 May 2017 16:35:53 +0000 (00:35 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 31 Jul 2017 22:11:50 +0000 (17:11 -0500)
commitd2fcb92b18f735b7ea623ea649f3aedcacf48677
treef3bdc5f32dff424d04e2736d29d8c17637befc17
parente59084b5b2daa22427d3dc4e1fd241f69910615e
block: Reuse bs as backing hd for drive-backup sync=none

Opening the backing image for the second time is bad, especially here
when it is also in use as the active image as the source. The
drive-backup job itself doesn't read from target->backing for COW,
instead it gets data from the write notifier, so it's not a big problem.
However, exporting the target to NBD etc. won't work, because of the
likely stale metadata cache.

Use BDRV_O_NO_BACKING in this case and manually set up the backing
BdrvChild.

Cc: qemu-stable@nongnu.org
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit fc0932fdcfc3e5cafa3641e361b681c07f639812)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
blockdev.c