]> git.proxmox.com Git - mirror_qemu.git/commit
pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 30 Jan 2024 00:27:12 +0000 (19:27 -0500)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 30 Jan 2024 21:17:59 +0000 (16:17 -0500)
commitd5eaeefbdac30d9ca62612f18e2d3f4509272856
treef17eaa64bf0d30544048642fbf9650e21f387783
parent615eaeab3d318ba239d54141a4251746782f65c1
pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

The following expression is incorrect because blk_pread_nonzeroes()
deals in units of bytes, not sectors:

  bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS)
                                              ^^^^^^^

BDRV_REQUEST_MAX_BYTES is the appropriate constant.

Fixes: a4b15a8b9ef2 ("pflash: Only read non-zero parts of backend image")
Cc: Xiang Zheng <zhengxiang9@huawei.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240130002712.257815-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
hw/block/block.c