]> git.proxmox.com Git - mirror_qemu.git/commit
vhost-vsock: fix migration issue when seqpacket is supported
authorStefano Garzarella <sgarzare@redhat.com>
Tue, 21 Sep 2021 16:16:41 +0000 (18:16 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 5 Oct 2021 21:30:57 +0000 (17:30 -0400)
commitd6a9378f47515c6d70dbff4912c5740c98709880
tree8124ecd638031b0323bf8e090a23f5cc5cd35f4f
parentd6ed27bae717ceac9de0c53a31389143846b8465
vhost-vsock: fix migration issue when seqpacket is supported

Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support")
enabled the SEQPACKET feature bit.
This commit is released with QEMU 6.1, so if we try to migrate a VM where
the host kernel supports SEQPACKET but machine type version is less than
6.1, we get the following errors:

    Features 0x130000002 unsupported. Allowed features: 0x179000000
    Failed to load virtio-vhost_vsock:virtio
    error while loading state for instance 0x0 of device '0000:00:05.0/virtio-vhost_vsock'
    load of migration failed: Operation not permitted

Let's disable the feature bit for machine types < 6.1.
We add a new OnOffAuto property for this, called `seqpacket`.
When it is `auto` (default), QEMU behaves as before, trying to enable the
feature, when it is `on` QEMU will fail if the backend (vhost-vsock
kernel module) doesn't support it.

Fixes: 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support")
Cc: qemu-stable@nongnu.org
Reported-by: Jiang Wang <jiang.wang@bytedance.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20210921161642.206461-2-sgarzare@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/core/machine.c
hw/virtio/vhost-vsock.c
include/hw/virtio/vhost-vsock.h