]> git.proxmox.com Git - mirror_qemu.git/commit
dma-helpers: Fix race condition of continue_after_map_failure and dma_aio_cancel
authorFam Zheng <famz@redhat.com>
Mon, 16 Mar 2015 09:03:37 +0000 (17:03 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 27 Apr 2015 16:24:18 +0000 (18:24 +0200)
commite95205e1f9cd2c4262b7a7b1c992a94512c86d0e
tree1c03e53eeb46e2d7c15b9c15a1f1c9414e254e6e
parent33b6c2edf6214f02b9beaea61b169506c01f90aa
dma-helpers: Fix race condition of continue_after_map_failure and dma_aio_cancel

If DMA's owning thread cancels the IO while the bounce buffer's owning thread
is notifying the "cpu client list", a use-after-free happens:

     continue_after_map_failure               dma_aio_cancel
     ------------------------------------------------------------------
     aio_bh_new
                                              qemu_bh_delete
     qemu_bh_schedule (use after free)

Also, the old code doesn't run the bh in the right AioContext.

Fix both problems by passing a QEMUBH to cpu_register_map_client.

Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1426496617-10702-6-git-send-email-famz@redhat.com>
[Remove unnecessary forward declaration. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
dma-helpers.c
exec.c
include/exec/cpu-common.h