]> git.proxmox.com Git - mirror_qemu.git/commit
qemu-storage-daemon: Fix non-string --object properties
authorKevin Wolf <kwolf@redhat.com>
Thu, 16 Apr 2020 15:26:06 +0000 (17:26 +0200)
committerKevin Wolf <kwolf@redhat.com>
Thu, 30 Apr 2020 15:51:07 +0000 (17:51 +0200)
commiteaae29ef89d498d0eac553c77b554f310a47f809
tree89b54cf0c904c6b2681ae9e500b0f8fdb05556b2
parentd6a5beeb2bbf4f5ce6e6396051fb4c5fcced56a4
qemu-storage-daemon: Fix non-string --object properties

After processing the option string with the keyval parser, we get a
QDict that contains only strings. This QDict must be fed to a keyval
visitor which converts the strings into the right data types.

qmp_object_add(), however, uses the normal QObject input visitor, which
expects a QDict where all properties already have the QType that matches
the data type required by the QOM object type.

Change the --object implementation in qemu-storage-daemon so that it
doesn't call qmp_object_add(), but calls user_creatable_add_dict()
directly instead and pass it a new keyval boolean that decides which
visitor must be used.

Reported-by: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
include/qom/object_interfaces.h
qemu-storage-daemon.c
qom/object_interfaces.c
qom/qom-qmp-cmds.c