]> git.proxmox.com Git - mirror_qemu.git/commit
rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}
authorMarkus Armbruster <armbru@redhat.com>
Tue, 28 Mar 2017 08:55:59 +0000 (10:55 +0200)
committerJeff Cody <jcody@redhat.com>
Tue, 28 Mar 2017 13:53:16 +0000 (09:53 -0400)
commiteb87203b646c27938ecb11d7766c5c98f836241f
treee7de1b14ca289a33dac393235a0a206e66b1844d
parent142b9ca51d7260d20f6e87bd7f2020ac0a7d95d9
rbd: Reject -blockdev server.*.{numeric, to, ipv4, ipv6}

We use InetSocketAddress in the QAPI schema.  However, the code
doesn't use inet_connect_saddr(), but formats "host" and "port" into a
configuration string for rados_conf_set().  Thus, members "numeric",
"to", "ipv4" and "ipv6" are silently ignored.  Not nice.  Example:

    -blockdev rbd,node-name=nn,pool=p,image=i,server.0.host=h0,server.0.port=12345,server.0.ipv4=off

Factor a suitable InetSocketAddressBase out of InetSocketAddress, and
use that.  "numeric", "to", "ipv4" and "ipv6" are now rejected.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 1490691368-32099-2-git-send-email-armbru@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
qapi-schema.json
qapi/block-core.json