]> git.proxmox.com Git - mirror_qemu.git/commit
string-output-visitor: show structs as "<omitted>"
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 12 Dec 2023 13:49:34 +0000 (08:49 -0500)
committerKevin Wolf <kwolf@redhat.com>
Thu, 21 Dec 2023 21:49:28 +0000 (22:49 +0100)
commitff32bb53476539d352653f4ed56372dced73a388
tree0805bcfad6e519065fafcabfea932a7d98f2aa2f
parentc12887e1b087e8f69d217ccae3dc7b1d059f3db3
string-output-visitor: show structs as "<omitted>"

StringOutputVisitor crashes when it visits a struct because
->start_struct() is NULL.

Show "<omitted>" instead of crashing. This is necessary because the
virtio-blk-pci iothread-vq-mapping parameter that I'd like to introduce
soon is a list of IOThreadMapping structs.

This patch is a quick fix to solve the crash, but the long-term solution
is replacing StringOutputVisitor with something that can handle the full
gamut of values in QEMU.

Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20231212134934.500289-1-stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
include/qapi/string-output-visitor.h
qapi/string-output-visitor.c