]> git.proxmox.com Git - mirror_qemu.git/commit
mirror: Drop permissions on s->target on completion
authorKevin Wolf <kwolf@redhat.com>
Mon, 29 May 2017 12:08:32 +0000 (14:08 +0200)
committerKevin Wolf <kwolf@redhat.com>
Mon, 29 May 2017 13:37:26 +0000 (15:37 +0200)
commit63c8ef289087a225d445319d047501d4fe593687
treef056c0eefd0c16112218e54f74013ff8c90ebf2f
parenta896f7f26a1a0417322463439825073c1a917e41
mirror: Drop permissions on s->target on completion

This fixes an assertion failure that was triggered by qemu-iotests 129
on some CI host, while the same test case didn't seem to fail on other
hosts.

Essentially the problem is that the blk_unref(s->target) in
mirror_exit() doesn't necessarily mean that the BlockBackend goes away
immediately. It is possible that the job completion was triggered nested
in mirror_drain(), which looks like this:

    BlockBackend *target = s->target;
    blk_ref(target);
    blk_drain(target);
    blk_unref(target);

In this case, the write permissions for s->target are retained until
after blk_drain(), which makes removing mirror_top_bs fail for the
active commit case (can't have a writable backing file in the chain
without the filter driver).

Explicitly dropping the permissions first means that the additional
reference doesn't hurt and the job can complete successfully even if
called from the nested blk_drain().

Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
block/mirror.c