]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - block/bio.c
block: cleanup bio_alloc_bioset()
authorIngo Molnar <mingo@elte.hu>
Sat, 21 Feb 2009 10:16:36 +0000 (11:16 +0100)
committerJens Axboe <jens.axboe@oracle.com>
Tue, 24 Mar 2009 11:35:16 +0000 (12:35 +0100)
commit34053979fb1d923217685cf166349f1899980581
tree05e4c9dd49fe841ecb5c6556aa3a5deaf05fab75
parent8e0ee43bc2c3e19db56a4adaa9a9b04ce885cd84
block: cleanup bio_alloc_bioset()

this warning (which got fixed by commit b2bf968):

  fs/bio.c: In function ‘bio_alloc_bioset’:
  fs/bio.c:305: warning: ‘p’ may be used uninitialized in this function

Triggered because the code flow in bio_alloc_bioset() is correct
but a bit complex for the compiler to see through.

Streamline it a bit - this also makes the code a tiny bit more compact:

   text    data     bss     dec     hex filename
   7540     256      40    7836    1e9c bio.o.before
   7539     256      40    7835    1e9b bio.o.after

Also remove an older compiler-warnings annotation from this function,
it's not needed.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
fs/bio.c