]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/dax.c
dax: set errors in mapping when writeback fails
authorJeff Layton <jlayton@redhat.com>
Thu, 6 Jul 2017 11:02:27 +0000 (07:02 -0400)
committerJeff Layton <jlayton@redhat.com>
Thu, 6 Jul 2017 11:02:27 +0000 (07:02 -0400)
commit819ec6b91d5ba1ca313066a306461774eff6b567
treeea15ae590baa0a64d810c6bdbc9895dc30c22d92
parentacbf3c3452c3729829fdb0e5a52fed3cce556eb2
dax: set errors in mapping when writeback fails

Jan Kara's description for this patch is much better than mine, so I'm
quoting it verbatim here:

DAX currently doesn't set errors in the mapping when cache flushing
fails in dax_writeback_mapping_range(). Since this function can get
called only from fsync(2) or sync(2), this is actually as good as it can
currently get since we correctly propagate the error up from
dax_writeback_mapping_range() to filemap_fdatawrite()

However, in the future better writeback error handling will enable us to
properly report these errors on fsync(2) even if there are multiple file
descriptors open against the file or if sync(2) gets called before
fsync(2). So convert DAX to using standard error reporting through the
mapping.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-and-tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
fs/dax.c