]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/dcache.c
vfs: do the careful dentry name access for all dentry_cmp cases
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 10 May 2012 19:19:19 +0000 (12:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 11 May 2012 02:54:09 +0000 (19:54 -0700)
commit94753db5ed9ad97582ef453127d9626a7a2be602
treeebf9b6cce17c3f4348a598988cb398a9807b3db7
parent8c01a529b861ba97c7d78368e6a5d4d42e946f75
vfs: do the careful dentry name access for all dentry_cmp cases

Commit 12f8ad4b0533 ("vfs: clean up __d_lookup_rcu() and dentry_cmp()
interfaces") did the careful ACCESS_ONCE() of the dentry name only for
the word-at-a-time case, even though the issue is generic.

Admittedly I don't really see gcc ever reloading the value in the middle
of the loop, so the ACCESS_ONCE() protects us from a fairly theoretical
issue. But better safe than sorry.

Also, this consolidates the common parts of the word-at-a-time and
bytewise logic, which includes checking the length.  We'll be changing
that later.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/dcache.c