]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit - fs/namespace.c
fs: namespace: suppress 'may be used uninitialized' warnings
authorTim Gardner <tim.gardner@canonical.com>
Thu, 28 Aug 2014 17:26:03 +0000 (11:26 -0600)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 9 Oct 2014 06:39:10 +0000 (02:39 -0400)
commitb8850d1fa8e2f6653e57daf6d08e58c5f5eb2c85
tree5648df7e01da32afbbf962a8c73b54111fd50f5f
parent8ba7f6c2faada3ad553518b9febbdce7a988359b
fs: namespace: suppress 'may be used uninitialized' warnings

The gcc version 4.9.1 compiler complains Even though it isn't possible for
these variables to not get initialized before they are used.

fs/namespace.c: In function ‘SyS_mount’:
fs/namespace.c:2720:8: warning: ‘kernel_dev’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  ret = do_mount(kernel_dev, kernel_dir->name, kernel_type, flags,
        ^
fs/namespace.c:2699:8: note: ‘kernel_dev’ was declared here
  char *kernel_dev;
        ^
fs/namespace.c:2720:8: warning: ‘kernel_type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  ret = do_mount(kernel_dev, kernel_dir->name, kernel_type, flags,
        ^
fs/namespace.c:2697:8: note: ‘kernel_type’ was declared here
  char *kernel_type;
        ^

Fix the warnings by simplifying copy_mount_string() as suggested by Al Viro.

Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/compat.c
fs/internal.h
fs/namespace.c