]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
staging/rts5208: fix incorrect shift to extract upper nybble
authorColin Ian King <colin.king@canonical.com>
Fri, 18 Aug 2017 13:34:16 +0000 (14:34 +0100)
committerSeth Forshee <seth.forshee@canonical.com>
Sun, 10 Sep 2017 23:08:41 +0000 (18:08 -0500)
commit3bfa1924769e596911176bf028eef2280d7ed65d
treec08eb204de43708add2df716147ec3b46e7a7802
parent6de27b27a4c7100e6568e645981db3ec409650fc
staging/rts5208: fix incorrect shift to extract upper nybble

BugLink: http://bugs.launchpad.net/bugs/1716284
commit 34ff1bf4920471cff66775dc39537b15c5f0feff upstream.

The mask of sns_key_info1 suggests the upper nybble is being extracted
however the following shift of 8 bits is too large and always results in
0.  Fix this by shifting only by 4 bits to correctly get the upper nybble.

Detected by CoverityScan, CID#142891 ("Operands don't affect result")

Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/staging/rts5208/rtsx_scsi.c