]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
ASoC: bcm2835: Enforce full symmetry
authorMatthias Reichl <hias@horus.com>
Sun, 7 May 2017 14:24:57 +0000 (16:24 +0200)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 16 Feb 2018 22:11:52 +0000 (17:11 -0500)
commit44fb4abf94a0124c18309cc362104813b6ff390c
tree35f88b08c0b1e0eb9377dbcb7e2ace04d2809c88
parent187a8e6115330a3dcf963e339f566dcd56d90dd2
ASoC: bcm2835: Enforce full symmetry

bcm2835's configuration registers can't be changed when a stream
is running, which means asymmetric configurations aren't supported.

Channel and rate symmetry are already enforced by constraints
but samplebits had been missed.

As hw_params doesn't check for symmetry constraints by itself
and just returns success if a stream is running this led to
situations where asymmetric configurations were seeming to
succeed but of course didn't work because the hardware wasn't
configured at all.

Fix this by adding the missing samplerate symmetry constraint.

Signed-off-by: Matthias Reichl <hias@horus.com>
sound/soc/bcm/bcm2835-i2s.c