]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
arm64: ptrace: Fix incorrect get_user() use in compat_vfp_set()
authorDave Martin <Dave.Martin@arm.com>
Thu, 29 Jun 2017 14:25:49 +0000 (15:25 +0100)
committerWill Deacon <will.deacon@arm.com>
Thu, 29 Jun 2017 16:44:08 +0000 (17:44 +0100)
commit5fbd5fc49fc39ac8433da62d16682a1d0217ea4f
tree82733204697236c0171030a6ec506782fb2d1ca0
parent16d38acb12d065ebe3494e4e31e8b4438f3214da
arm64: ptrace: Fix incorrect get_user() use in compat_vfp_set()

Now that compat_vfp_get() uses the regset API to copy the FPSCR
value out to userspace, compat_vfp_set() looks inconsistent.  In
particular, compat_vfp_set() will fail if called with kbuf != NULL
&& ubuf == NULL (which is valid usage according to the regset API).

This patch fixes compat_vfp_set() to use user_regset_copyin(),
similarly to compat_vfp_get().

This also squashes a sparse warning triggered by the cast that
drops __user when calling get_user().

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/ptrace.c