]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
netfilter: ipvs: fix incorrect conflict resolution
authorFlorian Westphal <fw@strlen.de>
Tue, 18 Apr 2017 15:49:56 +0000 (17:49 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 19 Apr 2017 15:55:17 +0000 (17:55 +0200)
commitbe7be6e161a218e92c4e46b97ba59c1e40cfea9c
tree24b0d71b0fd286541141d712c771dba839bb3ba2
parent01026edef9062b7d26ace74a5b4a5a33a2399501
netfilter: ipvs: fix incorrect conflict resolution

The commit ab8bc7ed864b9c4f1fcb00a22bbe4e0f66ce8003
("netfilter: remove nf_ct_is_untracked")
changed the line
   if (ct && !nf_ct_is_untracked(ct) && nfct_nat(ct)) {
   to
   if (ct && nfct_nat(ct)) {

meanwhile, the commit 41390895e50bc4f28abe384c6b35ac27464a20ec
("netfilter: ipvs: don't check for presence of nat extension")
from ipvs-next had changed the same line to

  if (ct && !nf_ct_is_untracked(ct) && (ct->status & IPS_NAT_MASK)) {

When ipvs-next got merged into nf-next, the merge resolution took
the first version, dropping the conversion of nfct_nat().

While this doesn't cause a problem at the moment, it will once we stop
adding the nat extension by default.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/ipvs/ip_vs_ftp.c