]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
netfilter: nf_log: don't call synchronize_rcu in nf_log_unset
authorFlorian Westphal <fw@strlen.de>
Tue, 25 Apr 2017 08:24:03 +0000 (10:24 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 1 May 2017 09:19:07 +0000 (11:19 +0200)
commitc83fa19603bdaeef17b815713dbbe3230c8a34ee
tree49a16567ef8b98dcf448ea4adf391c3097ccbdab
parent933bd83ed60e80ebb1aeb64a2f7cd3190d2312e2
netfilter: nf_log: don't call synchronize_rcu in nf_log_unset

nf_log_unregister() (which is what gets called in the logger backends
module exit paths) does a (required, module is removed) synchronize_rcu().

But nf_log_unset() is only called from pernet exit handlers. It doesn't
free any memory so there appears to be no need to call synchronize_rcu.

v2: Liping Zhang points out that nf_log_unregister() needs to be called
after pernet unregister, else rmmod would become unsafe.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_log.c
net/netfilter/nfnetlink_log.c