]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
KVM: nVMX: fix nested_vmx_check_vmptr failure paths under debugging
authorRadim Krčmář <rkrcmar@redhat.com>
Fri, 19 May 2017 13:48:51 +0000 (15:48 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 30 May 2017 15:17:21 +0000 (17:17 +0200)
commitcbf712792b6e61317b93dd56dd5c0784363c9ac9
tree9e3120f4bc4032961a5219b6aed54cbb28a9b03f
parent52b5419016997f2960e9c8b6584c4acb3875d126
KVM: nVMX: fix nested_vmx_check_vmptr failure paths under debugging

kvm_skip_emulated_instruction() will return 0 if userspace is
single-stepping the guest.

kvm_skip_emulated_instruction() uses return status convention of exit
handler: 0 means "exit to userspace" and 1 means "continue vm entries".
The problem is that nested_vmx_check_vmptr() return status means
something else: 0 is ok, 1 is error.

This means we would continue executing after a failure.  Static checker
noticed it because vmptr was not initialized.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 6affcbedcac7 ("KVM: x86: Add kvm_skip_emulated_instruction and use it.")
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx.c